This repository has been archived by the owner on Oct 12, 2018. It is now read-only.
Delete resources in reverse order #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@ericchiang any updates here? |
|
none yet. I still need to get a cluster up so I can test #21 |
|
I can send you privately credentials to a test cluster. |
This was referenced May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change you made works great, but if the resources in the manifest file depend on creation order, the deletion should be in reverse order, this PR addresses that.
I have tested, and it works like a charm.
This PR merges against #21
Thanks for the quick turnaround you've provided!