Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements on forms setup #435

Merged
merged 10 commits into from
Sep 22, 2023

Conversation

@kentcdodds
Copy link
Member

Thanks for this! Most of these changes are great. I have a question about some of them though. I left comments in the commits you linked. Here they are:

38cc886#commitcomment-128116470

0077095#commitcomment-128116651

If you could answer those, then we can get this merged. Thank you very much!

@kentcdodds kentcdodds force-pushed the optimize-conform-setup branch from cd37b2a to 1e3c583 Compare September 22, 2023 19:08
@kentcdodds
Copy link
Member

I reverted those commits. If you can help me understand why they're necessary, we can add those back in later. Thanks!

@kentcdodds kentcdodds merged commit b8f146b into epicweb-dev:main Sep 22, 2023
4 checks passed
@edmundhung edmundhung deleted the optimize-conform-setup branch September 27, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants