-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed propagation of exceptions from upstream endpoints #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adubovik
force-pushed
the
fix/various-fixes
branch
from
November 22, 2024 17:51
6a994c6
to
4a595cf
Compare
adubovik
force-pushed
the
fix/various-fixes
branch
from
November 22, 2024 17:54
4a595cf
to
905defe
Compare
… headers in errors
adubovik
force-pushed
the
fix/various-fixes
branch
from
November 26, 2024 11:53
d66488d
to
94f8b2a
Compare
adubovik
force-pushed
the
fix/various-fixes
branch
from
November 26, 2024 15:33
d92d847
to
cb64f48
Compare
adubovik
commented
Nov 26, 2024
adubovik
requested review from
igorlagutin and
roman-romanov-o
and removed request for
igorlagutin
November 26, 2024 15:43
…oroutine to Awaitable type
adubovik
force-pushed
the
fix/various-fixes
branch
from
November 26, 2024 16:11
cb3b7b6
to
065c875
Compare
adubovik
changed the title
fix: various fixes
fix: fixed propagation of exceptions from upstream endpoints
Nov 26, 2024
roman-romanov-o
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_debug
constant was evaluated before the log level was set)object
fields were concatenated which resulted in"object": "chat.completionchat.completionchat.completion"
. Added a test witnessing the bugfix.en_core_web_sm
model is (a) downloaded as part of the package build and (b) pre-loaded on the server start-up instead of spending time of the first request into PII interceptoren_core_web_sm
model (3.7.1) and spacy (3.7.5) to avoid model downloading issue on the server start upaiohttp
tohttpx
, thusaiohttp
is removed from the package dependenciesaiostream
package dependency moved to theexamples
extrasaidial-sdk
0.13.0 to 0.16.0X-UPSTREAMS
header and refactored DIAL Client to ease interceptor testinghandle_streaming_errors
method used to do). This led toChatCompletionInterceptor.call_upstreams
changing type to accommodate the new kind of stream values which hold DIAL Exception._UnstructuredChunk
toArbitraryChunk
from DIAL SDK