Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gemini support #953

Merged
merged 5 commits into from
Dec 23, 2023
Merged

feat: add gemini support #953

merged 5 commits into from
Dec 23, 2023

Conversation

yihong0618
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Dec 19, 2023
@fangyinc
Copy link
Collaborator

Thanks, I'll verify it later.

fangyinc
fangyinc reviewed Dec 19, 2023
View reviewed changes
dbgpt/config.py Outdated Show resolved Hide resolved
@yihong0618
Copy link
Contributor Author

@fangyinc fixed

fangyinc
fangyinc previously requested changes Dec 20, 2023
View reviewed changes
dbgpt/model/proxy/llms/gemini.py Outdated Show resolved Hide resolved
Aralhi
Aralhi reviewed Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@Aralhi Aralhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your effort, it will be better declare in frontend. /web/utils/constants.ts MODEL_ICON_MAP. such as
bard_proxyllm: { label: 'bard_proxyllm', icon: '/models/bard.gif' }

@yihong0618
Copy link
Contributor Author

thank you for your effort, it will be better declare in frontend. /web/utils/constants.ts MODEL_ICON_MAP. such as bard_proxyllm: { label: 'bard_proxyllm', icon: '/models/bard.gif' }

I checked but there's no icon for gemini yet...https://blog.google/technology/ai/google-gemini-ai/

@fangyinc
Copy link
Collaborator

https://blog.google/technology/ai/google-gemini-ai/

Can we use this icon? https://storage.googleapis.com/gweb-uniblog-publish-prod/images/final_keyword_header.width-1200.format-webp.webp

image

@yihong0618
Copy link
Contributor Author

https://blog.google/technology/ai/google-gemini-ai/

Can we use this icon? https://storage.googleapis.com/gweb-uniblog-publish-prod/images/final_keyword_header.width-1200.format-webp.webp

image

yes we can ....

@yihong0618
Copy link
Contributor Author

https://blog.google/technology/ai/google-gemini-ai/

Can we use this icon? https://storage.googleapis.com/gweb-uniblog-publish-prod/images/final_keyword_header.width-1200.format-webp.webp
image

yes we can but it seems not the real icon..

@Aralhi
Copy link
Collaborator

Aralhi commented Dec 20, 2023

thank you for your effort, it will be better declare in frontend. /web/utils/constants.ts MODEL_ICON_MAP. such as bard_proxyllm: { label: 'bard_proxyllm', icon: '/models/bard.gif' }

I checked but there's no icon for gemini yet...https://blog.google/technology/ai/google-gemini-ai/

how about using deepmind logo 😊, https://avatars.githubusercontent.com/u/8596759?s=200&v=4

@Aralhi
Copy link
Collaborator

Aralhi commented Dec 20, 2023

https://blog.google/technology/ai/google-gemini-ai/

Can we use this icon? https://storage.googleapis.com/gweb-uniblog-publish-prod/images/final_keyword_header.width-1200.format-webp.webp

image

it is so BIG. not appropriate in icon.

@yihong0618
Copy link
Contributor Author

https://blog.google/technology/ai/google-gemini-ai/

Can we use this icon? https://storage.googleapis.com/gweb-uniblog-publish-prod/images/final_keyword_header.width-1200.format-webp.webp
image

it is so BIG. not appropriate in icon.

yep, and there may be copyright issues, how about just draw one using AI

@Aralhi
Copy link
Collaborator

Aralhi commented Dec 20, 2023

https://blog.google/technology/ai/google-gemini-ai/

Can we use this icon? https://storage.googleapis.com/gweb-uniblog-publish-prod/images/final_keyword_header.width-1200.format-webp.webp
image

it is so BIG. not appropriate in icon.

yep, and there may be copyright issues, how about just draw one using AI

since there is no avaliable icon, keep simple, how about using google icon or huggingface icon(default icon)

@csunny
Copy link
Collaborator

csunny commented Dec 20, 2023

@Aralhi I prefer the Google icon. 😄

@fangyinc
Copy link
Collaborator

Please review @csunny @Aralhi

csunny

This comment was marked as duplicate.

Sign in to view

@yihong0618 yihong0618 dismissed csunny’s stale review December 21, 2023 06:22

The merge-base changed after approval.

csunny
csunny previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@yihong0618 yihong0618 dismissed csunny’s stale review December 21, 2023 06:30

The merge-base changed after approval.

@Aralhi Aralhi requested a review from fangyinc December 21, 2023 08:34
@fangyinc fangyinc dismissed their stale review December 22, 2023 02:12

To others.

csunny
csunny approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

fangyinc
fangyinc approved these changes Dec 23, 2023
View reviewed changes
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@fangyinc fangyinc merged commit 12234ae into eosphoros-ai:main Dec 23, 2023
4 checks passed
vshy108 pushed a commit to vshy108/DB-GPT that referenced this pull request Jan 18, 2024
@yihong0618 @fangyinc
feat: add gemini support (eosphoros-ai#953)
32742d5 
Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: Fangyin Cheng <[email protected]>
Co-authored-by: Fangyin Cheng <[email protected]>
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
@yihong0618 @fangyinc @Hopshine
feat: add gemini support (eosphoros-ai#953)
0d61eb2 
Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: Fangyin Cheng <[email protected]>
Co-authored-by: Fangyin Cheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aralhi Aralhi Aralhi left review comments

@fangyinc fangyinc fangyinc approved these changes

@csunny csunny csunny approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yihong0618 @fangyinc @Aralhi @csunny