Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the issue that lost prev observation memory in toolExpert bug (#2136) #2137

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

cinjoseph
Copy link
Contributor

@cinjoseph cinjoseph commented Nov 19, 2024

…136)

Description

Close #2136

How Has This Been Tested?

prompt after fix

human: 最近消息记录:
Question: 使用get_current_system_time获取当前时间戳 
Thought: {
  "thought": "用户希望使用get_current_system_time工具来获取当前的时间戳。",
  "tool_name": "get_current_system_time",
  "args": {}
} 
Observation: 1731575527 
用户输入: Read the result data of the dependent steps in the above historical message to complete the current goal:使用format_time_stamp将时间戳转换为'yy-mm-dd'格式

output after fix

full stream output:
{
  "thought": "为了满足用户需求,需要先从历史消息中提取出当前的时间戳,然后使用format_time_stamp工具将其转换成指定的日期格式。",
  "tool_name": "format_time_stamp",
  "args": {
    "timestamp_str": "1731575527"
  }
}

>>>>>>>>LuBan Action report: 
execution succeeded,
24:11:14 17:12:07

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the fix Bug fixes label Nov 19, 2024
@cinjoseph cinjoseph marked this pull request as draft November 19, 2024 11:24
Copy link
Collaborator

@yhjun1026 yhjun1026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. r+

@csunny csunny marked this pull request as ready for review November 19, 2024 13:47
@csunny csunny merged commit 4efe643 into eosphoros-ai:main Nov 19, 2024
5 checks passed
@Aries-ckt
Copy link
Collaborator

Close #2136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [MutliAgent] lost previous tools result in prompt when ToolExpert call tools repeatedly
4 participants