Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:chroma store refactor #1508

Merged
merged 6 commits into from
May 11, 2024
Merged

feat:chroma store refactor #1508

merged 6 commits into from
May 11, 2024

Conversation

Aries-ckt
Copy link
Collaborator

@Aries-ckt Aries-ckt commented May 10, 2024 •
edited
Loading

Description

Close #1503

How Has This Been Tested?

python examples/rag/embedding_rag_example.py

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the enhancement New feature or request label May 10, 2024
csunny
csunny previously approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, core lib no longer dependent on langchain directly，🚀

@csunny
Copy link
Collaborator

csunny commented May 11, 2024

Please remove langchain from setup.py

csunny
csunny previously approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

fangyinc
fangyinc previously approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt requested review from csunny and fangyinc May 11, 2024 08:13
fangyinc
fangyinc approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

csunny
csunny approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit d313155 into eosphoros-ai:main May 11, 2024
4 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
@Aries-ckt @Hopshine
feat:chroma store refactor (eosphoros-ai#1508)
7528d68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangyinc fangyinc fangyinc approved these changes

@csunny csunny csunny approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [Knowledge] sync file error.
3 participants
@Aries-ckt @csunny @fangyinc