Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rag): Fix CrossEncoderRanker bug of EmbeddingRetriever #1504

Merged
merged 2 commits into from
May 10, 2024

Conversation

ivanzhu109
Copy link
Contributor

When using EmbeddingRetriever with reranking specified as CrossEncoderRanker, a TypeError ('Object of type float32 is not JSON serializable') occurs when attempting to serialize references of the answer.
image
image

@github-actions github-actions bot added the fix Bug fixes label May 9, 2024
@ivanzhu109
Copy link
Contributor Author

@csunny it seems like a code type check error.
#1502 (comment)
image

csunny
csunny previously approved these changes May 9, 2024
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM~

@csunny
Copy link
Collaborator

csunny commented May 9, 2024

@ivanzhu109 I checked the styles and everything looks normal. emm~

Copy link
Contributor Author

@ivanzhu109 ivanzhu109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csunny emm~

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit 8eb64d7 into eosphoros-ai:main May 10, 2024
4 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants