FLAGINT-44-add-new-entries-api #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the default options
… soon when v3 APIs are release
…PI url to be stored as this.newUrl in EnvoyAPI
…Unit tests Added as well
… nested workObject object in its args.
… accept query params for filtering results.
…y, loginAsUser tests
…stallConfig() instead
| this.baseUrl = process.env.ENVOY_BASE_URL || 'https://app.envoy.com'; | ||
| this.newUrl = 'https://api.envoy.com/v1'; |
There was a problem hiding this comment.
We should probably call this something more descriptive than newUrl, maybe baseApiUrl and add an env var for it. Also, we should probably remove the v1 on it so that it's just the api.envoy.com domain.
| this.baseUrl = process.env.ENVOY_BASE_URL || 'https://app.envoy.com'; | ||
| this.newUrl = 'https://api.envoy.com/v1'; | ||
| // External OAuth login url | ||
| this.envoyAuthUrl = 'https://app.envoy.com/a/auth/v0/authorize?response_type=code'; |
There was a problem hiding this comment.
How are we planning to use this? Currently integrations payloads include an integrations scoped JWT and a user scoped JWT for making calls so most integrations will not need to call auth directly.
Style note, a url constant should not have parameters on it. The ?response_type=code should be added in place when the url is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.