build/vhd2v_converter: allows using an instance instead of entity_name + params #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current approach with VHD2VConverter is to pass a dict with parameters, input/output signals and the top_entity name.
For a existing code using Instance this imply to rework code to replace
instancebydict.This PR allows VHD2VConverter to receive by CTOR an instance. In this mode it will be able to extract entity name and parameters from Instance and create a new one with only port
This PR also do build_dir optional: When not provided at constructor time build_dir will be filled with build/platform_name/vhd2v