soc/integration/soc: Fix CSRBridge Bus Width conversion #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe |
|
Thanks @FlyGoat! Testing this in CI could indeed be interesting and should not be too complicated with the current CI in place, we could add some I just need to look at the CI failing test (related to the new assert) and we'll be able to merge. |
Wishbone2CSR and AXILite2CSR bridges are incapable for performing bus width conversion, which means it's Bus slave port must have same width as CSRs. Use CSR width to create slave bus to allow width adaptar to be inserted by add_slave. Also add relevant assertion. Signed-off-by: Jiaxun Yang <[email protected]>
FlyGoat
force-pushed
the
csr-bridge-width
branch
from
7615c91 to
c52a2ca
Compare
|
@enjoy-digital Sorry for the oversight, CI is now fixed. It was due to difference on default bus parameters. I'm working on a soc_bus test case, will PR when it's ready. Thanks |
|
Thanks @FlyGoat, this is merged. |
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wishbone2CSR and AXILite2CSR bridges are incapable for performing bus width conversion, which means it's Bus slave port must have same width as CSRs.
Use CSR width to create slave bus to allow width adaptar to be inserted by add_slave. Also add relevant assertion.
This fixes
--bus-data-width 64build.