Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/align codestyle #513

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

spinnerok
Copy link
Contributor

In the first commit I have added a config file for swiftlint and aligned code to (almost) default config. In the second I have enabled some additional rules.
Most of the changes in this PR are changes in white spaces and were made by swiftlint automatically.

@spinnerok
Copy link
Contributor Author

@leeway1208 Can we merge this or discuss how to proceed? I can split commits in separate PRs or do every setting in a separate commit. Or should I adjust some rules?

@leeway1208
Copy link
Collaborator

Hi. Sorry for late reply as we have CNY holiday break. I am not sure if .swiftlint.yml file has used the third part library and I may need to add New Run Script Phase in build phases? Thanks.

@spinnerok spinnerok force-pushed the feature/align-codestyle branch from 65831b9 to dc87dc0 Compare April 19, 2023 12:02
@spinnerok
Copy link
Contributor Author

spinnerok commented Apr 19, 2023

@leeway1208 Unfortunately swiftlint should be installed separately. It is not a part of a tool chain. You can install it using brew on MacOS.

brew install swiftlint

To run I just use the following command:

swiftlint lint --quiet

The quiet flag will hide all the processed files while still allows to see all issues.

And to adjust some simple deviations in style I use:

swiftlint --fix

For more information you can check a git repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants