Skip to content

Commit

Permalink
Merge pull request #666 from emoacht/develop
Browse files Browse the repository at this point in the history
Revert method name and edit comments
  • Loading branch information
emoacht authored Dec 27, 2024
2 parents 5dd5818 + 8b91da5 commit 1350f7a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions Source/StartupAgency/PipeHolder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ public PipeHolder(string name, Func<string[], Task<string>> handleRequestAsync)
/// <param name="args">Arguments being forwarded to another instance</param>
/// <returns>
/// <para>created: True if no other instance exists and this instance successfully creates the semaphore</para>
/// <para>started: True if this instance successfully starts the named pipe server</para>
/// <para>response: Response from another instance if that instance exists and returns an response</para>
/// <para>started: True if this instance successfully starts a named pipe server</para>
/// <para>response: Response from another instance if that instance exists and returns a response</para>
/// </returns>
public (bool created, bool started, string response) CreateAndStart(string[] args)
public (bool created, bool started, string response) Create(string[] args)
{
_semaphore = new Semaphore(1, 1, SemaphoreName, out bool createdNew);
if (createdNew)
Expand Down Expand Up @@ -80,7 +80,7 @@ public PipeHolder(string name, Func<string[], Task<string>> handleRequestAsync)
}

/// <summary>
/// Releases <see cref="System.Threading.Semaphore"/> to stop named pipes.
/// Releases <see cref="System.Threading.Semaphore"/> and stops named pipes.
/// </summary>
public void Release()
{
Expand Down
2 changes: 1 addition & 1 deletion Source/StartupAgency/StartupAgent.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public class StartupAgent : IDisposable
throw new ArgumentNullException(nameof(startupTaskId));

_holder = new PipeHolder(name, null);
var (created, started, response) = _holder.CreateAndStart(forwardingArguments?.ToArray());
var (created, started, response) = _holder.Create(forwardingArguments?.ToArray());
if (!created)
return (success: false, response);

Expand Down

0 comments on commit 1350f7a

Please sign in to comment.