Allow admins to change names/email addresses on accounts #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment this includes _any_ user change (including self-initiated ones). Perhaps this should be filtered down to just relevant fields? Also this page is getting a bit long, now.
This makes Flask Debug Toolbar's SQLAlchemy queries thing work.
marksteward
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1092.
Note that this adds (another) N+1 query to the admin users page. We currently have a few, because of polymorphic purchases and relationships we don't eagerly prefetch.
Given this is admin-side, though, it's unlikely to be too much a problem, but I'm noting it now...