Create cfp invite form v2 #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marksteward
requested changes
Feb 4, 2024
migrations/versions/872d00e6369e_add_cfp_invite_reason_column_to_user.py
Outdated
Show resolved
Hide resolved
SamLR
force-pushed
the
create-cfp-invite-form-v2
branch
4 times, most recently
from
db7d741 to
df31f96
Compare
marksteward
approved these changes
Feb 8, 2024
This will let us invite a speaker, track that they are an invited speaker (because there's something in the 'cfp_invite_reason') and then generate a login url for them that will redirect them to fill in the appropriate form for their cfp.
There may be some back and forth for invited proposals before they're accepted but we don't want them to change state. Also adds the 'is_editable' property to stop that being hardcoded
Mostly so pre-existing users that we have invited can be 'invited'
SamLR
force-pushed
the
create-cfp-invite-form-v2
branch
from
df31f96 to
ea47cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at the 'invite speaker flow' (post chat with @Jonty).
closes #1327 & #813
Flow is now:
cfp_invite_reasonset on them (this is a new column on the user).nextset tocfp.formthat they can return to the speaker (assumption is that there will be an existing on going conversation so this is preferable to a new email thread).cfp_invite_reasonall their proposals go straight to themanual-reviewstate (which is now editable) so we can track them easily.The cfp form flow has also been updated so that users with the
cfp_invite_reasoncan always submit new proposals (which go straight to manual review) this should avoid the need to use theignore_closeflows around the CfP.