Move Venues list into the database #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venues now have a list of proposal types for which they: * can be selected (allowed_types) * are in the default allowed set for (default_for_types) Venues also have a capacity, and proposals are now associated with allowed venues using a foreign key rather than a comma-separated string. There's some slightly hairy logic inside the migrations to properly populate capacity/default_for_types/allowed_types/allowed_venues the first time; some of these migrations are lossy in the reverse direction (so don't do that). Realistically speaking there needs to be some better logic here, because actually different venues can host different _types_ at different times, but we don't yet represent venue-slots in any meaningful sense in the data model. Fixes emfcamp#1210.
russss
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Venues now have a list of proposal types for which they:
Venues also have a capacity, and proposals are now associated with allowed venues using a foreign key rather than a comma-separated string.
There's some slightly hairy logic inside the migrations to properly populate capacity/default_for_types/allowed_types/allowed_venues the first time; some of these migrations are lossy in the reverse direction (so don't do that).
Realistically speaking there needs to be some better logic here, because actually different venues can host different types at different times, but we don't yet represent venue-slots in any meaningful sense in the data model.
Fixes #1210.