Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Update to Ember CLI 5.12.0 #81

Merged
merged 4 commits into from
Dec 22, 2024

Conversation

jrjohnson
Copy link
Contributor

Updated using ember-cli-update do update all blueprints and dependencies.

This is breaking:

  • Drops support for node < 18
  • Drop support for ember < 4.12

Technically this just drops tests for these older things. I left in the macroCondition(dependencySatisfies('ember-source' for earlier ember versions as I don't think these have to go away today.

The linting config has changes that I applied as well.

Using ember-cli-update to update dependencies and blueprints to the
latest LTS CLI release.
Small changes in the prettier config in the default bluerpint. Applied
here.
This is no longer recommended and is a linting violation. Removed them.
As this is the entire point of this code
@jrjohnson jrjohnson marked this pull request as ready for review December 22, 2024 20:11
@jrjohnson
Copy link
Contributor Author

@chriskrycho - first step to unlock #80

@chriskrycho
Copy link
Contributor

Seems reasonable; I think that makes this Breaking, right?

@jrjohnson
Copy link
Contributor Author

Yup, I think so. I put that in the PR title, but can't l label.

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Excellent! I’ll add the label and merge it!

@chriskrycho chriskrycho merged commit fe6e203 into emberjs:master Dec 22, 2024
9 checks passed
@jrjohnson jrjohnson deleted the update-ember-512 branch December 22, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants