Skip to content

Commit

Permalink
Merge pull request #152 from ember-animation/drop-ember-4.4
Browse files Browse the repository at this point in the history
Drop support for Ember.js 4.4 and below
  • Loading branch information
SergeAstapov authored Dec 27, 2023
2 parents aa49ac3 + 612f80b commit fa45e84
Show file tree
Hide file tree
Showing 4 changed files with 77 additions and 43 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,11 @@ jobs:
fail-fast: false
matrix:
try-scenario:
- ember-lts-3.16
- ember-lts-3.20
- ember-lts-3.24
- ember-lts-3.28
- ember-lts-4.8
- ember-lts-4.12
- ember-release
- ember-beta
- ember-canary
- ember-classic
- embroider-safe
- embroider-optimized

Expand Down
46 changes: 46 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: Publish

on:
push:
branches:
- main
- master
tags:
- v*

jobs:
publish:
name: Publish
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8.x

- name: Install Node
uses: actions/setup-node@v4
with:
node-version: 18.x
cache: 'pnpm'
# This creates an .npmrc that reads the NODE_AUTH_TOKEN environment variable
registry-url: 'https://registry.npmjs.org'

- name: Install Dependencies
run: pnpm install --frozen-lockfile

# We need a workspace aware version of npm because our addon is in a subdir but our .npmrc is in the root
- name: npm8
run: npm install -g npm@8

# We need a workspace aware version of npm because our addon is in a subdir but our .npmrc is in the root
- name: copy .md files
run: cp README.md LICENSE.md CHANGELOG.md addon/

- name: npm publish
run: npm publish --tag=latest --verbose --workspace=addon
env:
NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}
25 changes: 25 additions & 0 deletions .github/workflows/push-dist.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Because this library needs to be built,
# we can't easily point package.json files at the git repo for easy cross-repo testing.
#
# This workflow brings back that capability by placing the compiled assets on a "dist" branch
# (configurable via the "branch" option below)
name: Push dist

on:
push:
branches:
- main
- master

jobs:
push-dist:
name: Push dist
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: wyvox/action-setup-pnpm@v3
- uses: kategengler/[email protected]
with:
branch: dist
token: ${{ secrets.GITHUB_TOKEN }}
working-directory: addon
42 changes: 4 additions & 38 deletions test-app/config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,34 +8,18 @@ module.exports = async function () {
usePnpm: true,
scenarios: [
{
name: 'ember-lts-3.16',
name: 'ember-lts-4.8',
npm: {
devDependencies: {
'ember-source': '~3.16.10',
'ember-source': '~4.8.0',
},
},
},
{
name: 'ember-lts-3.20',
name: 'ember-lts-4.12',
npm: {
devDependencies: {
'ember-source': '~3.20.7',
},
},
},
{
name: 'ember-lts-3.24',
npm: {
devDependencies: {
'ember-source': '~3.24.3',
},
},
},
{
name: 'ember-lts-3.28',
npm: {
devDependencies: {
'ember-source': '~3.28.0',
'ember-source': '~4.12.0',
},
},
},
Expand Down Expand Up @@ -63,24 +47,6 @@ module.exports = async function () {
},
},
},
{
name: 'ember-classic',
env: {
EMBER_OPTIONAL_FEATURES: JSON.stringify({
'application-template-wrapper': true,
'default-async-observers': false,
'template-only-glimmer-components': false,
}),
},
npm: {
devDependencies: {
'ember-source': '~3.28.0',
},
ember: {
edition: 'classic',
},
},
},
embroiderSafe(),
embroiderOptimized(),
],
Expand Down

0 comments on commit fa45e84

Please sign in to comment.