Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make popwin don't treat the only window as popup. #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make popwin don't treat the only window as popup. #124

wants to merge 1 commit into from

Conversation

zk-phi
Copy link

@zk-phi zk-phi commented Jun 6, 2015

When the user invoked delete-other-windows command to enlarge the popup window, for example, we should no longer treat the only window as a popup I think.

@m2ym
Copy link
Contributor

m2ym commented Jun 7, 2015

I don't understand what "treat the only window as popup" means.

@zk-phi
Copy link
Author

zk-phi commented Jun 7, 2015

"There're no other windows than the popwin:popup-window", I mean.

One may want to enlarge the popup window by killing all other windows (delete-other-windows) and it produces the condition. A problem is, that unintuitively the only window is still a popup window (that is, (eq (selected-window) popwin:popup-window)), so it can unexpectedly closed or reused by popwin later. For example, when I split the window and switch to the new window, then the old one is closed.

  1. M-x popwin:popup-buffer *scratch*[RET]
  2. C-x 1 (delete-other-windows)
  3. C-x 2 (split-window-below)
  4. C-x o (other-window)
  5. → the window is closed (unexpectedly)

I think this is not very intuitive behavior, so when there's only one window, popwin should behave as if the popup window is already closed and the only window is no longer a popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants