feat: chrome extension support #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsirion
reviewed
Apr 1, 2024
Kodylow
force-pushed
the
chrome-extension
branch
from
fb14245 to
6da5287
Compare
Kodylow
force-pushed
the
chrome-extension
branch
from
6da5287 to
df3307b
Compare
|
When you run |
elsirion
approved these changes
Apr 2, 2024
Comment on lines
+63
to
+122
| if [ -n "${scriptContent}" ]; then | ||
| echo "${scriptContent}" >./dist/.stage/initWebimint.js | ||
| echo "Replacing original script tag in index.html with reference to initWebimint.js" | ||
| sed -i 's|<script type=module>[^<]*</script>|<script type="module" src="/initWebimint.js"></script>|' "${indexHtmlFile}" | ||
| else # using trunk serve, multiline script tags, have to extract line by line | ||
| echo "Using trunk serve, multiline script tags, have to extract line by line" | ||
| echo "Extracting script content from index.html and creating separate .js files" | ||
| # Directory where the new JS files will be stored | ||
| JS_DIR="./dist/.stage/js" | ||
| mkdir -p "$JS_DIR" | ||
| # Counter to name the extracted JS files uniquely | ||
| COUNTER=1 | ||
| # Temporary file to hold the modified HTML content | ||
| TMP_HTML=$(mktemp) | ||
| # Initialize SCRIPT_OPEN to 0 before the loop | ||
| SCRIPT_OPEN=0 | ||
| # Read the index.html file line by line | ||
| while IFS= read -r line || [[ -n "$line" ]]; do | ||
| if [[ $line =~ \<script.*\>\</script\> ]]; then | ||
| # Inline script tag with no content, just copy the line | ||
| echo "$line" >>"$TMP_HTML" | ||
| elif [[ $line =~ \<script.*\>(.*) ]]; then | ||
| # Opening script tag with potential inline content | ||
| SCRIPT_OPEN=1 | ||
| # Capture any content on the same line as the opening script tag | ||
| SCRIPT_CONTENT="${BASH_REMATCH[1]}" | ||
| if [[ $SCRIPT_CONTENT ]]; then | ||
| # If there's inline content right after the script tag, add a newline to start accumulating correctly | ||
| SCRIPT_CONTENT+=$'\n' | ||
| fi | ||
| elif [[ $line =~ \</script\> ]]; then | ||
| # Closing script tag, write content to a new JS file | ||
| SCRIPT_FILE="$JS_DIR/extracted_$COUNTER.js" | ||
| echo "$SCRIPT_CONTENT" >"$SCRIPT_FILE" | ||
| # Replace the script tag in HTML with a reference to the new JS file | ||
| echo "<script type=\"module\" src=\"/js/extracted_$COUNTER.js\"></script>" >>"$TMP_HTML" | ||
| COUNTER=$((COUNTER + 1)) | ||
| SCRIPT_OPEN=0 | ||
| SCRIPT_CONTENT="" # Reset SCRIPT_CONTENT for the next script | ||
| elif [[ $SCRIPT_OPEN -eq 1 ]]; then | ||
| # Inside a script tag, accumulate the content | ||
| SCRIPT_CONTENT+="$line"$'\n' | ||
| else | ||
| # Outside script tags, just copy the line | ||
| echo "$line" >>"$TMP_HTML" | ||
| fi | ||
| done <"${indexHtmlFile}" | ||
| # Replace the original HTML file with the modified one | ||
| mv "$TMP_HTML" "${indexHtmlFile}" | ||
| # Clean up | ||
| rm -f "$TMP_HTML" | ||
| # Replace placeholder trunk address in JavaScript files | ||
| echo "Replacing {{__TRUNK_ADDRESS__}} placeholder in extracted JavaScript files" | ||
| jsFiles=$(find ./dist/.stage/js -iname "*.js") | ||
| TRUNK_ADDRESS=127.0.0.1:8080 | ||
| for file in $jsFiles; do | ||
| sed -i "s/{{__TRUNK_ADDRESS__}}/${TRUNK_ADDRESS}/g" "$file" | ||
| echo "Replaced in: $file" | ||
| done | ||
| fi |
There was a problem hiding this comment.
Do I even want to know if this was written by GPT? 😆 What a glorious bash script!
There was a problem hiding this comment.
yup haha, but it works
There was a problem hiding this comment.
"Let's have a LLM at junior dev level at best, that sometimes hallucinates, code in a write-only language, what should possibly go wrong" 🤣 (I'm no stranger to this though https://github.com/elsirion/fedimint-observer/blob/181aa61e3be51993bd531d9b072375f2f0113618/src/federation/query.html#L1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loads webimint as a chrome extension