Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leptos v0.6.5 #40

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Leptos v0.6.5 #40

merged 6 commits into from
Feb 13, 2024

Conversation

sectore
Copy link
Collaborator

@sectore sectore commented Oct 8, 2023

incl. nix flake update

Note: Upstreams needs to be updated to latest Leptos, too:

Closes #36

Still errors - mostly upstream related (leptos-icons, leptos-qr-scanner)
@sectore sectore marked this pull request as draft October 8, 2023 17:52
@HaosGames
Copy link

If https://github.com/bankai-labs/leptos-icons/ isn't going to be updated anymore maybe a switch to https://github.com/Carlosted/leptos-icons could be done.

@ngutech21
Copy link

leptos-qr-scanner has been updated and supports leptos 0.6: 5830bd6f75d7836189ef1434f71a10222a737a44
leptos 0.6 didn't change the client api, so the upgrade from 0.5 should be easy. If the leptos-icons lib gets replaced as proposed by @HaosGames I think webimint could be upgraded.

@elsirion
Copy link
Owner

elsirion commented Feb 9, 2024

Yep, just need to find the time to get back to webimint, but Fedimint is keeping me rather busy these days.

@sectore
Copy link
Collaborator Author

sectore commented Feb 9, 2024

Thx @ngutech21 ! No need to use another lib just for icons, those can be embedded as plain SVG into a Leptos app easily. I'm going to finish this PR within next days ...

use latest leptos-qr-scanner, deactivate icons, run `nix flake update`
@sectore
Copy link
Collaborator Author

sectore commented Feb 11, 2024

With latest update of 6df204a the build failed with different errors, mostly thrown by Leptos server_fn-0.6.5 crate (see build logs from line 1098. Do we need to update the Rust version? If so, how do to that with fedimint's flake?

@sectore sectore changed the title Leptos v0.5.1 Leptos v0.6.5 Feb 11, 2024
@sectore sectore requested a review from elsirion February 11, 2024 14:21
@elsirion
Copy link
Owner

Do we need to update the Rust version? If so, how do to that with fedimint's flake?

We can't just update the fedimint flake input since fedimint itself is still on rust 1.73 while we need 1.75. It might be worth setting up flakebox directly for webimint instead of relying on fedimint.

@sectore sectore mentioned this pull request Feb 12, 2024
@sectore
Copy link
Collaborator Author

sectore commented Feb 12, 2024

Using Flakebox introduced by #56, everything compiles now. Please merge #56 before this PR here.

trunk serve

2024-02-12T14:10:38.760781Z  INFO ✅ success
2024-02-12T14:10:38.763043Z  INFO 📡 serving static assets at -> /
2024-02-12T14:10:38.763055Z  INFO 📡 server listening at http://127.0.0.1:8080
trunk build --release

2024-02-12T14:14:15.501822Z  INFO ✅ success

@sectore sectore marked this pull request as ready for review February 12, 2024 14:19
@sectore sectore mentioned this pull request Feb 12, 2024
@elsirion
Copy link
Owner

Seems like merging #56 first lead to some merge conflicts 😬

@sectore sectore merged commit fa100dc into master Feb 13, 2024
1 check passed
@sectore sectore deleted the feat/36-update-leptos branch February 13, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Leptos v0.5.0
4 participants