-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames #89
Renames #89
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 7
Lines ? 783
Branches ? 0
=======================================
Hits ? 783
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 15 of 15 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DylanMeeus)
functions/main.go, line 53 at r1 (raw file):
{"Map", "map.go", ForAll}, {"Unique", "unique.go", ForNumbersAndStrings}, {"FilterNot", "filternot.go", ForAll},
These need to be sorted by the function name. You will also need to update the README.
functions/filternot.go, line 1 at r1 (raw file):
package functions
Please rename this file to filter_not.go
Woops sorry, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix up the merge conflict.
Reviewable status: complete! all files reviewed, all discussions resolved
Looks like it has no conflicts now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
Hey Elliot,
I've done the renames that we discussed in #86
I altered the unit tests to reflect the changes in the names. All unit tests passed when I ran them, so I'm thinking this should work :)
~ Dylan
This change is