Fix inconsistent printing of meditation #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issues I observed while solving the koans. Some of the issues I noticed are: - Random vertical position of printing koans - Sometimes koan intro printed before clear screen - Next koan does not appear when all koan passes for a module
This improves progress bar by: - Adding progress percentage - Calculating progress bar underline based on the text length of progress bar
felipesere
reviewed
Mar 1, 2024
| end | ||
|
|
||
| defp calculate_progress(current, total) do | ||
| round(current / total * @progress_bar_length) | ||
| end | ||
|
|
||
| defp calculate_percentage(current, total) do | ||
| Float.round(current / total * 100, 1) |
There was a problem hiding this comment.
I wonder if this would look better without any decimal places?
0 of 12 -> 0% complete
There was a problem hiding this comment.
I thought it would be useful for people like me who wants to know the progress a little more precisely. But either way it's fine doesn't matter too much.
There was a problem hiding this comment.
I don't have a strong opinion. I tend to agree that decimals aren't terribly useful in this context.
iamvery
reviewed
Mar 5, 2024
felipesere
approved these changes
Mar 27, 2024
|
Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues I observed while solving the koans. Some of the issues I noticed are: