Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The worker/2 function from the Supervisor.Spec module is deprecated #287

Closed
wants to merge 3 commits into from
Closed

The worker/2 function from the Supervisor.Spec module is deprecated #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2285643
The worker/2 function from the Supervisor.Spec module is deprecated
0dayfall Dec 28, 2023
55bd24c
Update elixir-version in github worksflows to v1.5
0dayfall Jan 4, 2024
6d0e8d7
Update elixir-version in github worksflows to v1.5
0dayfall Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/elixir.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Set up Elixir
uses: erlef/setup-beam@988e02bfe678367a02564f65ca2e37726dc0268f
with:
elixir-version: '1.12.3' # Define the elixir version [required]
elixir-version: '1.5' # Define the elixir version [required]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ What this meant to be 1.15? I think the latest is 1.16.

Copy link
Author

@0dayfall 0dayfall Jan 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I should change to 1.16 instead, I made a new pull request by mistake.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #288

otp-version: '24.1' # Define the OTP version [required]
- name: Restore dependencies cache
uses: actions/cache@v2
Expand Down
10 changes: 4 additions & 6 deletions lib/elixir_koans.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@ defmodule ElixirKoans do
use Application

def start(_type, _args) do
import Supervisor.Spec

children = [
worker(Display, []),
worker(Tracker, []),
worker(Runner, []),
worker(Watcher, [])
{Display, []},
{Tracker, []},
{Runner, []},
{Watcher, []}
]

opts = [strategy: :one_for_one, name: ElixirKoans.Supervisor]
Expand Down
Loading