-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atoms koan #105
Atoms koan #105
Conversation
list = [name: "Jay"] | ||
|
||
assert map[:name] == ___ | ||
assert list[:name] == ___ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lesson doesn't feel nearly as useful without the next two.
Allowing expressions in answers seems pretty hard to do :) I'd happily merge this PR without the problematic koans. |
We were able to allow expressions in answers (see https://github.com/iamvery/elixir-koans/pull/21/files#r60759404), but doing so on this project would require major changes to have answers are inserted in test. Probably not worth it for these examples, but could be a fun endeavor regardless. The basic difference on that other project was instead of answers being injected as arguments to the defined function, the entire function was rewritten with blanks replaced by answers themselves. |
We can't pull this off right now since answers can't be expressions.
Not really useful without showing dot access.
Updated. Rebased and addressed the things we talked about. |
Porting over atoms koans from iamvery/elixir-koans. Unfortunately there are a couple that don't work with the way answers are implemented here. Worth trying to address? Throw them away?