Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atoms koan #105

Merged
merged 6 commits into from
May 5, 2016
Merged

Atoms koan #105

merged 6 commits into from
May 5, 2016

Conversation

iamvery
Copy link
Collaborator

@iamvery iamvery commented May 5, 2016

Porting over atoms koans from iamvery/elixir-koans. Unfortunately there are a couple that don't work with the way answers are implemented here. Worth trying to address? Throw them away?

list = [name: "Jay"]

assert map[:name] == ___
assert list[:name] == ___
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lesson doesn't feel nearly as useful without the next two.

@ukutaht
Copy link
Collaborator

ukutaht commented May 5, 2016

Allowing expressions in answers seems pretty hard to do :) I'd happily merge this PR without the problematic koans.

@iamvery
Copy link
Collaborator Author

iamvery commented May 5, 2016

We were able to allow expressions in answers (see https://github.com/iamvery/elixir-koans/pull/21/files#r60759404), but doing so on this project would require major changes to have answers are inserted in test. Probably not worth it for these examples, but could be a fun endeavor regardless.

The basic difference on that other project was instead of answers being injected as arguments to the defined function, the entire function was rewritten with blanks replaced by answers themselves.

@iamvery
Copy link
Collaborator Author

iamvery commented May 5, 2016

Updated. Rebased and addressed the things we talked about.

@ukutaht ukutaht merged commit 3e163a2 into elixirkoans:master May 5, 2016
@iamvery iamvery deleted the atoms-koan branch May 6, 2016 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants