Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor FolderManager code improvements #1489

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Minor FolderManager code improvements #1489

wants to merge 4 commits into from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Nov 25, 2024 •
edited
Loading

  • Although unlikely for local files, FolderManager.File objects are not guaranteed to have a non-null FileInfo - this is now checked before dereferencing in is_valid_directory and icon.
  • No use is currently made of the ability to suppress hidden files in the folder (they are shown de-emphasised instead) so associated code is removed
  • is_valid_directory and is_valid_textfile are now both properties and are only determined once to improve performance.

@jeremypw jeremypw changed the title Jeremypw/minor code improvements Minor FolderManager code improvements Nov 25, 2024
@jeremypw jeremypw marked this pull request as ready for review November 25, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeremypw