Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for PostgreSQL 11 and 12 #18034

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Dec 16, 2024

This is essentially matrix-org/synapse#14392. I didn't see anything in there about updating sytest or complement.

The main driver of this is so that I can use jsonb_path_exists in #17488. 😄

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@github-actions github-actions bot deployed to PR Documentation Preview December 16, 2024 16:15 Active
@clokep
Copy link
Contributor Author

clokep commented Dec 16, 2024

I think the failures are flakes, I had a full green run on my account: https://github.com/clokep/synapse/actions/runs/12358363779

@clokep clokep marked this pull request as ready for review December 16, 2024 19:29
@clokep clokep requested a review from a team as a code owner December 16, 2024 19:29
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks for adding to the upgrade notes as well!

I didn't see anything in there about updating sytest or complement.

Complement: We have a Synapse Complement container image, which is on PG13 already.

Sytest: Sytest's CI makes use of the sytest-synapse container image, which is built using Debian bullseye. Bullseye uses postgres13.

So we're good for this upgrade, but will need to edit CI config in the case of Postgres 14+!

@anoadragon453 anoadragon453 merged commit 2d23250 into element-hq:develop Dec 19, 2024
38 of 41 checks passed
@clokep
Copy link
Contributor Author

clokep commented Dec 19, 2024

Thank you!

@clokep clokep deleted the bump-postgres branch December 19, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants