Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make admin api redactions use the requester to send the redaction #18029

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

morguldir
Copy link
Contributor

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@morguldir morguldir requested a review from a team as a code owner December 15, 2024 23:46
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this! I'm surprised this wasn't covered by a unit test, which means it could break again in future.

Would you be willing to write a test (likely here) that tests redacting events from a remote user? You can use the inject_event test utility to create and send events from remote users (usage example).

@H-Shay
Copy link
Contributor

H-Shay commented Dec 20, 2024

@morguldir thanks for catching this and fixing it. @anoadragon453 this should be fixed - if you need a test to merge this PR, I've added one here.

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM. I've also confirmed that #18043 passes only once the changes in this PR are applied.

Thank you!

(Note: CI failures here are unrelated to this PR.)

@anoadragon453 anoadragon453 merged commit 7c2284b into element-hq:develop Dec 23, 2024
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants