Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nix flake to use nixpkgs-unstable in lieu of master #17852

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Improve nix flake to use nixpkgs-unstable in lieu of master #17852

merged 5 commits into from
Nov 6, 2024

Conversation

SuperSandro2000
Copy link
Contributor

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@SuperSandro2000 SuperSandro2000 requested a review from a team as a code owner October 20, 2024 22:58
@CLAassistant
Copy link

CLAassistant commented Oct 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SuperSandro2000
Don't use nixpkgs/master
53fff6c 
It contains the absolutely latest and greatest bugs of commits merged 5
minutes ago. nixpkgs-unstable is usually only a few days behind master
but has passed basic tests and ensures at least something works.
@SuperSandro2000
Remove unused arg
b6b9596
@SuperSandro2000
Fix formatting of multiline string
7922454
@SuperSandro2000
Add changelog entry
42318f7
reivilibre
reivilibre approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@reivilibre reivilibre changed the title Improve flake Improve nix flake to use nixpkgs-unstable in lieu of master Nov 6, 2024
@reivilibre reivilibre merged commit 75698a3 into element-hq:develop Nov 6, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivilibre reivilibre reivilibre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperSandro2000 @CLAassistant @reivilibre