-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4140: don't cancel delayed state on own state #17810
base: develop
Are you sure you want to change the base?
MSC4140: don't cancel delayed state on own state #17810
Conversation
Depends on matrix-org/complement#742 for Complement tests to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the whole, just some small points of feedback.
if delta.event_id is None: | ||
logger.debug( | ||
"Not handling delta for deleted state: %r %r", | ||
delta.event_type, | ||
delta.state_key, | ||
) | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of interest, would it be worth instead adding an argument to get_partial_current_state_deltas
to filter out state deltas that do not have an associated event ID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be helpful, yes. Since that's not strictly required for this PR, though, I opened a new one for it: #17833
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was decided out-of-band to not pursue adding that argument, so let's leave this as it is.
The sytests pass when I run them locally. Is there a way to retry their CI runs? |
@AndrewFerr Retried 👍 |
When a user sends a state event, do not cancel their own delayed events for the same piece of state.
d45595c
to
4ecbe62
Compare
Now the only failing tests are the ones that depend on matrix-org/complement#742 (finally!). |
When a user sends a state event, do not cancel their own delayed events for the same piece of state.
For context, see the relevant section in the MSC.
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)