-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically update the year in the footer #17328
base: develop
Are you sure you want to change the base?
Conversation
Hi @MomentQYC, thanks for your PR! I'm just checking with our legal team whether we're allowed to do this 😋 (because it would be convenient). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it turns out that the copyright date in the footer of the website should reflect either:
- The original publication date only (so, just
© 2023
), or - The original publication date to (
-
) the date the content on the page was most recently edited (© 2023-2024
).
Since the content of this page isn't actually being updated dynamically, then the copyright header doesn't need to be updated either. We can either leave the date as © 2023
, or update the footer (© 2023-X
) whenever the page is edited.
Personally I'm leaning towards 1. (the current state) as it's less work, but I appreciate that it's then a magnet for people wanting to update it. I also thought that copyright dates in website footers should always reflect the current year!
I think the best thing to do would to add a page to our documentation about copyright headers and footers repeating what I've explained above, and then link to that from here (and any other related spots in the codebase). If you'd like to take that on, go for it! Otherwise I accept that it's probably more work than you signed up for.
And again, we appreciate the effort of the original PR :)
I apologize for the delay in the middle. |
Dynamically update the year in the footer
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)