-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background blur feature for supported devices #2812
base: livekit
Are you sure you want to change the base?
Conversation
how do we deal with lk modules that dont fullfill the ts lints? |
18af76e
to
2830224
Compare
f76fc2d
to
21230ee
Compare
I found what we needed: |
2daf807
to
00b500b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested some cleanup. Furthermore I think you could deduplicate some of the code into something like a useBlur()
or canBlur()
. This might make adding tests easier too.
8f5aca9
to
3f85d8a
Compare
I think @robintown has an idea how we might be able to reuse the track from the lobby to the in call view. Than this might come for free. But in this pr we should at least get rid of the duplicated |
- still should not work without a fixing upstream LK: livekit/components-js#1042 livekit/components-js#1043
dcb8a21
to
1860646
Compare
wasmLoaderPath: new URL( | ||
"../../node_modules/@mediapipe/tasks-vision/wasm/vision_wasm_internal.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use
import wasmLoaderPath from "@mediapipe/tasks-vision/wasm/vision_wasm_internal.js?url";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did try that, but I ended up with a vite error and so did this approach instead. 🤷
This reverts commit 6b8dddf.
This adds background blur via @livekit/track-processors for supported browsers.
The option can be found in the video tab of the settings.
The fallback will be a greyed out checkbox (on firefox for instance)
This way firefox users get informed why it does not work on their side if other users tell them where to set it up.
Sadly this is not exactly done the way we would want to set it up see: livekit/track-processors-js#50