Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: avoid proxyquire in api_spec_slow #3786

Merged
merged 3 commits into from
Dec 13, 2024
Merged

test: avoid proxyquire in api_spec_slow #3786

merged 3 commits into from
Dec 13, 2024

Conversation

erickzhao
Copy link
Member

Small improvement for tests. We removed the forge install command in a v6 beta, but this test fixture still used proxyquire to stub that module.

Eliminating proxyquire here also improves type safety as forge was previously an any type.

@erickzhao erickzhao requested a review from a team as a code owner December 13, 2024 06:12
@erickzhao erickzhao changed the title spec: don't proxyquire slow api tests test: avoid proxyquire in api_spec_slow Dec 13, 2024
BlackHole1
BlackHole1 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzhao erickzhao added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 34c33fa Dec 13, 2024
12 checks passed
@erickzhao erickzhao deleted the less-proxyquire branch December 13, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erickzhao @BlackHole1