Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For every canary image build, create an image tag with the commit sha #2202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

For every canary image build, create an image tag with the commit sha #2202

wants to merge 2 commits into from

Conversation

alco
Copy link
Member

@alco alco commented Dec 20, 2024

Addresses #1921.

@alco alco requested review from magnetised and robacourt December 20, 2024 11:27
@alco alco changed the title For every canary image build, create a tag with the commit sha For every canary image build, create an image tag with the commit sha Dec 20, 2024
icehaunter
icehaunter approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@icehaunter icehaunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but I don't like having a spammed list of tags on DockerHub. A bit sad that we can't have both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icehaunter icehaunter icehaunter approved these changes

@magnetised magnetised Awaiting requested review from magnetised

@robacourt robacourt Awaiting requested review from robacourt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alco @icehaunter