Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a short guide on security. #2201

Merged
merged 5 commits into from
Dec 20, 2024
Merged

docs: add a short guide on security. #2201

merged 5 commits into from
Dec 20, 2024

Conversation

thruflo
Copy link
Contributor

@thruflo thruflo commented Dec 20, 2024

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 5a54426
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/67657d5ac403d0000819c6f6
😎 Deploy Preview https://deploy-preview-2201--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we make it clear that not locking down access is a very bad thing :-D

I'm also skeptical of the value of the key distribution example? It doesn't seem particularly useful in real-world e2e encrypted apps? Unless I'm missing something.


<<< @../../examples/encryption/src/Example.tsx{tsx}

### Key management
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a lot of experience with key distribution but isn't storing the key (unencrypted) alongside the encrypted data more-or-less make it basically the same as if it wasn't encrypted? Since anyone with access to the db can now decrypt whatever data they want?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could store keys in a different database and just sync the right ones. I do think that the point of Electric being good to sync keys is valid: it's just like the distributed config case. You need to share the right keys with the right users. What better mechanism?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 like I said I dunno — maybe if the key is encrypted before sharing so it's just a backup/cloud syncing mechanism.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have jigged the description a bit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately for e2e encryption you need to get keys into the client.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can have client-generated keys right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, but if you're sharing the data, you have to share keys.

website/docs/guides/security.md Outdated Show resolved Hide resolved
website/docs/guides/deployment.md Outdated Show resolved Hide resolved
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@thruflo thruflo merged commit caabf7c into main Dec 20, 2024
2 checks passed
@thruflo thruflo deleted the thruflo/security-guide branch December 20, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants