Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom agent deployer spec #335

Merged
merged 3 commits into from
May 17, 2022
Merged

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented May 17, 2022

What does this PR do?

Adds the required sped for the custom agent deployer

Why is it important?

to be able to properly validate the test structure

Checklist

Related issues

@marc-gr marc-gr added the enhancement New feature or request label May 17, 2022
@marc-gr marc-gr requested a review from a team as a code owner May 17, 2022 09:44
@marc-gr marc-gr requested a review from mtojek May 17, 2022 09:44
@elasticmachine
Copy link

elasticmachine commented May 17, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-17T09:53:05.032+0000

  • Duration: 2 min 17 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add a positive sample to the good package? For example a new data stream with a test?

changes:
- description: initial release
type: enhancement
link: https://github.com/elastic/package-spec/pull/131
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I used to link with the real PR number (so this one)

@mtojek mtojek self-requested a review May 17, 2022 09:53
@mtojek mtojek merged commit cdb867c into elastic:main May 17, 2022
@marc-gr marc-gr deleted the custom-agent-spec branch May 17, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants