-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of lists in 'Set ECS categorization fields' scripts #12161
base: main
Are you sure you want to change the base?
Conversation
These |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
Quality Gate passedIssues Measures |
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joegallo Is there any means of performing an automated escape analysis on these scripts? I'd love to be able to put a static check into our package test tooling.
There's nothing built into Elasticsearch for that yet, but I'm going to think about it -- I realize that the current approach of 'just be careful/perfect all the time' is untenable. |
Defensively copy list parameters in 'Set ECS categorization fields' scripts. See elastic/elasticsearch#91977.