Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of lists in 'Set ECS categorization fields' scripts #12161

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

joegallo
Copy link
Contributor

Defensively copy list parameters in 'Set ECS categorization fields' scripts. See elastic/elasticsearch#91977.

@joegallo joegallo added the bugfix Pull request that fixes a bug issue label Dec 19, 2024
@joegallo
Copy link
Contributor Author

These def hm = new HashMap(...) bits are trying to work around the linked bug, but I think they're mistaken.

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 19, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@marc-gr marc-gr marked this pull request as ready for review December 19, 2024 07:48
@marc-gr marc-gr requested review from a team as code owners December 19, 2024 07:48
@elasticmachine
Copy link

💚 Build Succeeded

History

@andrewkroh andrewkroh added Integration:system System Integration:watchguard_firebox WatchGuard Firebox Integration:windows Windows Integration:zscaler_zia Zscaler Internet Access Integration:authentik authentik Integration:proofpoint_on_demand Proofpoint On Demand Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Dec 19, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joegallo Is there any means of performing an automated escape analysis on these scripts? I'd love to be able to put a static check into our package test tooling.

@joegallo
Copy link
Contributor Author

@joegallo Is there any means of performing an automated escape analysis on these scripts? I'd love to be able to put a static check into our package test tooling.

There's nothing built into Elasticsearch for that yet, but I'm going to think about it -- I realize that the current approach of 'just be careful/perfect all the time' is untenable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:authentik authentik Integration:proofpoint_on_demand Proofpoint On Demand Integration:system System Integration:watchguard_firebox WatchGuard Firebox Integration:windows Windows Integration:zscaler_zia Zscaler Internet Access Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants