-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample to use updatecli to update mysql image #10652
Conversation
8e9bc68
to
39a1306
Compare
🚀 Benchmarks reportTo see the full report comment with |
39a1306
to
4847566
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shmsr added a couple of comments highlighting the parts that would be more relevant to manage each version upgrade. The rest is mostly boilerplate.
- name: Update mysql services. | ||
# --experimental needed for commitusingapi option. | ||
run: updatecli --experimental ${{ env.UPDATECLI_ACTION }} --config .github/workflows/updatecli-packages.d/mysql.yml --values .github/workflows/updatecli.d/scm.yml | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following this approach, an entry like this one would be needed for any service. We could try to find some way to run all the configs at once.
sources: | ||
latest: | ||
kind: dockerimage | ||
spec: | ||
image: mysql | ||
architecture: "linux/amd64" | ||
kind: latest | ||
tagfilter: '^8.\d*.\d*$' | ||
|
||
targets: | ||
mysqlTag: | ||
name: "mysql variant" | ||
kind: file | ||
spec: | ||
file: "packages/mysql/_dev/deploy/variants.yml" | ||
matchpattern: '(IMAGE: mysql:)8.*' | ||
replacepattern: '${1}{{ source "latest" }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This source and target would be the main part to configure for every version to upgrade.
Quality Gate passedIssues Measures |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |
Try to use updatecli to automatically update mysql variant image.
Related to elastic/elastic-package#1902.