Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch from elastic/elasticsearch-js#2078 #48

Closed
wants to merge 3 commits into from

Conversation

JoshMock
Copy link
Member

Patch applied from elastic/elasticsearch-js#2078

Rejected patch ./src/helpers.ts.rej must be resolved:

diff a/src/helpers.ts b/src/helpers.ts	(rejected hunks)
@@ -527,6 +527,8 @@ export default class Helpers {
    * @return {object} The possible operations to run with the datasource.
    */
   bulk<TDocument = unknown> (options: BulkHelperOptions<TDocument>, reqOptions: TransportRequestOptions = {}): BulkHelper<TDocument> {
+    assert(!(reqOptions.asStream ?? false), 'bulk helper: the asStream request option is not supported')
+
     const client = this[kClient]
     const { serializer } = client
     if (this[kMetaHeader] !== null) {

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@JoshMock
Copy link
Member Author

Closing. Patch was previously applied.

@JoshMock JoshMock closed this Mar 27, 2024
@JoshMock JoshMock deleted the create-pull-request/patch branch March 27, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants