Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow typo that is stopping the release of new version #716

Merged
merged 1 commit into from
May 14, 2024

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Fix workflow typo that is stopping the release of new version.

Details

The workflow got triggered after the merge of PR #711.

However there is a typo that sets the CREATE_TAG variable to =true instead of true, which causes the step Create tag to not run:

      - name: Create tag
        if: env.CREATE_TAG == 'true' # run only in case CREATE_TAG is true

You can see that in this run: https://github.com/elastic/elastic-serverless-forwarder/actions/runs/9079114205/job/24947621376.

How to test this PR locally

It is not possible to test this locally.

Best workaround would be to create your own private repository and create the same environment to make the workflow get triggered.

Signed-off-by: constanca <[email protected]>
@constanca-m constanca-m self-assigned this May 14, 2024
@constanca-m constanca-m merged commit acbe702 into elastic:main May 14, 2024
4 checks passed
@constanca-m constanca-m deleted the fix-workflow-typo branch May 14, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants