Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Mention that ESF may result in additional charges #446

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Aug 1, 2023

What does this PR do?

Adds a statement to the overview page in the ESF docs:

image

Note that I decided not to put this statement on the index page most users don't see the index page (google sends them to the overview).

Why is it important?

Users need to know in advance if they are doing something that might result in additional charges.

Checklist

  • My code follows the style guidelines of this project

Related issues

@dedemorton dedemorton added documentation Improvements or additions to documentation Team:Docs Label for the Observability docs team labels Aug 1, 2023
@dedemorton dedemorton self-assigned this Aug 1, 2023
@dedemorton dedemorton marked this pull request as draft August 1, 2023 01:21
@dedemorton dedemorton marked this pull request as ready for review August 1, 2023 01:29
@dedemorton
Copy link
Contributor Author

@ollyhowell Is this what you had in mind?
@tommyers-elastic Do we need to say more on the troubleshooting page?

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

File Coverage Lines Branches Missing
All files 100% 100% 100%
main_aws.py 100% 100% 100%
handlers/__init__.py 100% 100% 100%
handlers/aws/__init__.py 100% 100% 100%
handlers/aws/cloudwatch_logs_trigger.py 100% 100% 100%
handlers/aws/exceptions.py 100% 100% 100%
handlers/aws/handler.py 100% 100% 100%
handlers/aws/kinesis_trigger.py 100% 100% 100%
handlers/aws/replay_trigger.py 100% 100% 100%
handlers/aws/s3_sqs_trigger.py 100% 100% 100%
handlers/aws/sqs_trigger.py 100% 100% 100%
handlers/aws/utils.py 100% 100% 100%
share/__init__.py 100% 100% 100%
share/config.py 100% 100% 100%
share/events.py 100% 100% 100%
share/expand_event_list_from_field.py 100% 100% 100%
share/factory.py 100% 100% 100%
share/include_exlude.py 100% 100% 100%
share/json.py 100% 100% 100%
share/logger.py 100% 100% 100%
share/multiline.py 100% 100% 100%
share/secretsmanager.py 100% 100% 100%
share/utils.py 100% 100% 100%
shippers/__init__.py 100% 100% 100%
shippers/composite.py 100% 100% 100%
shippers/es.py 100% 100% 100%
shippers/factory.py 100% 100% 100%
shippers/logstash.py 100% 100% 100%
shippers/shipper.py 100% 100% 100%
storage/__init__.py 100% 100% 100%
storage/decorator.py 100% 100% 100%
storage/factory.py 100% 100% 100%
storage/payload.py 100% 100% 100%
storage/s3.py 100% 100% 100%
storage/storage.py 100% 100% 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against 8869243

@kaiyan-sheng
Copy link
Contributor

#449 is merged so this PR should pass the CI now. Thanks!

@dedemorton dedemorton merged commit f5c7927 into elastic:main Aug 8, 2023
@dedemorton dedemorton deleted the issue#444 branch August 8, 2023 18:50
@ollyhowell
Copy link
Contributor

@ollyhowell Is this what you had in mind? @tommyers-elastic Do we need to say more on the troubleshooting page?

This is great - thanks for picking this up and solving so quickly @dedemorton !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Review and improve guidance around AWS costs
3 participants