-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SSL in the Elastic Stack #789
Conversation
c72dd7c
to
7c912c1
Compare
62be326
to
55021bd
Compare
/test |
🌐 Coverage report
|
Opening for review. Additional testing on Windows would be nice, @ManojS-shetty has agreed to give it a try 🙂 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@jsoriano Followed the below steps to test this on windows virtual machine:
|
This looks like #856, let's confirm offline with logs. |
After looking to Manoj's logs, I couldn't find a reason why it was failing, it didn't seem related to #856, more testing is going to be needed. |
I did some manual testing on Windows and I found issues related to CRLF, see #869. After following the instructions added in this PR, |
Enable SSL in the Elastic Stack to ensure that everything works with recommended security settings.
Tasks:
(with hack)elastic-package test
worksTemplatize kibana config to useThis is not what I want to do, see comment.xpack.fleet.agents.elasticsearch.ca_sha256
.elastic-package stack up
completes. Print kibana and elasticsearch information on boot-up #861Fixes #654