Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move installation package in policy and system tests #1892

Merged
merged 12 commits into from
Jun 10, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jun 6, 2024

Part of #787
Supersedes #1845

Package installation process is repeated for every data stream and configuration file defined in every package (system and policy tests).

This process is just needed once:

  • No need to install multiple times the same package.
  • Every data stream and configuration file defines the required Package Policy.

This PR updates the runner to include two new methods in the interface (SetupRunner and TearDownRunner). These two methods are in charge of creating (or deleting) the global resources required to run all the tests for every data streams and configuration file defined in the package:

  • For system and policy tests, installation (and uninstallation) of the package would be performed in these two new methods.

Depends on #1866

@mrodm mrodm self-assigned this Jun 6, 2024
@mrodm
Copy link
Contributor Author

mrodm commented Jun 7, 2024

test integrations

@mrodm mrodm marked this pull request as ready for review June 7, 2024 10:50
@mrodm mrodm requested a review from a team June 7, 2024 10:52
@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repository to test this version. Check elastic/integrations#10099

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

internal/testrunner/runners/system/runner.go Outdated Show resolved Hide resolved
@mrodm mrodm enabled auto-merge (squash) June 10, 2024 08:55
@mrodm mrodm merged commit 52cb28b into elastic:main Jun 10, 2024
3 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm deleted the move_installation_package_system_tests branch June 11, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants