Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace agent names in condition to remove agent handler #1776

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Apr 16, 2024

Follows #1771

This PR removes the usage of Elastic Agent names as part of the condition used in the remove Agent handler.

A new field is added in the Info struct to set whether or not that service uses an independent Elastic Agent. Currently, this happens for packages using custom and k8s agents.

@mrodm mrodm self-assigned this Apr 16, 2024
@mrodm
Copy link
Contributor Author

mrodm commented Apr 16, 2024

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repository to test this version. Check elastic/integrations#9620

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mrodm

@@ -340,6 +340,8 @@ func (r *runner) createServiceInfo() (servicedeployer.ServiceInfo, error) {
svcInfo.OutputDir = outputDir
}

svcInfo.Agent.Independent = false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default services are not using independent agents

@mrodm mrodm changed the title Replace agent names in condition for remove agent handler Replace agent names in condition to remove agent handler Apr 16, 2024
@mrodm mrodm requested a review from a team April 16, 2024 17:09
@mrodm mrodm marked this pull request as ready for review April 16, 2024 17:09
@mrodm mrodm merged commit 44b84a6 into elastic:main Apr 17, 2024
3 checks passed
@mrodm mrodm deleted the replace_agent_names_in_remove_handler branch April 17, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants