Allow packages without service deployer to have system tests #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
reviewed
Apr 12, 2024
| @@ -0,0 +1,36 @@ | |||
| format_version: 3.1.3 | |||
| name: test_without_service_deployer | |||
| title: "Package with system tests and no service deployer." | |||
There was a problem hiding this comment.
Looking at the system test config , this package looks like the log input package from the integrations repository.
There was a problem hiding this comment.
This is basically the vanilla package created with elastic-package create package, with the system test and some additional fields.
mrodm
reviewed
Apr 12, 2024
|
Thanks @mrodm for the review! |
💚 Build Succeeded
History
cc @jsoriano |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to leverage the new custom definitions added in #1765, without forcing the packages to define a service deployer.
This is useful when the only requirement to test the package is a running agent, for example when collecting information from the system where it is running.
Part of #787