Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 8.10] Elastic-agent-autodiscover to v0.6.4 #3591

Merged
merged 3 commits into from
Oct 15, 2023

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Oct 12, 2023

  • Breaking change

What does this PR do?

WHAT: Update the Elastic-agent-autodiscover to v0.6.4. This disables by default metadata enrichment for deployment and cronjobs
WHY: The metadata enrichemnt for replicasets (which are produced from deployments) and cronjobs is proved a feature with heavy memory usage especially in big kubernetes clusters. The outcome was to enhance pods that were created from deployments and cronjobs with the relevant deployment/cronjob name. Decision

Why is it important?

We want to avoid the memory impact of keeping the feature enabled in big k8s clusters

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

@gizas gizas requested a review from a team as a code owner October 12, 2023 09:47
@gizas gizas requested review from faec, pchila, ChrsMark and tommyers-elastic and removed request for a team October 12, 2023 09:47
@mergify mergify bot assigned gizas Oct 12, 2023
@gizas gizas added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Oct 12, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-13T14:00:11.970+0000

  • Duration: 28 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 6317
Skipped 55
Total 6372

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gizas gizas changed the title Elastic-agent-autodiscover to v0.6.4 [backport 8.10] Elastic-agent-autodiscover to v0.6.4 Oct 12, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 12, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.765% (80/81) 👍
Files 67.944% (195/287) 👍
Classes 66.234% (357/539) 👍
Methods 53.125% (1122/2112) 👍
Lines 38.629% (12767/33050) 👍 0.012
Conditionals 100.0% (0/0) 💚

@gizas
Copy link
Contributor Author

gizas commented Oct 12, 2023

@cmacknz can I merge this as only vulncheck fails?

@gizas
Copy link
Contributor Author

gizas commented Oct 12, 2023

/test

@pierrehilbert
Copy link
Contributor

We just removed the govulncheck #3596

@gizas
Copy link
Contributor Author

gizas commented Oct 13, 2023

/test

@gizas
Copy link
Contributor Author

gizas commented Oct 13, 2023

@pierrehilbert, @cmacknz I have retried the test but still fails. It is the elastic-agent build so I am reluctant to merge. Can you have a look please?

@gizas
Copy link
Contributor Author

gizas commented Oct 13, 2023

/test

@pierrehilbert
Copy link
Contributor

Looks good to go this time.

@gizas gizas merged commit 22ed883 into 8.10 Oct 15, 2023
7 of 10 checks passed
@gizas gizas deleted the updating_agentautodiscovery_810 branch October 15, 2023 07:40
@bartoszcisek
Copy link

Can you please make it at least configurable? We use kubernetes.deployment do distinguish between pod types while configuring elastic-agent. Hint based discovery is still limited so we rely on condition based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants