Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code for ECS 8.11 #365

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Generate code for ECS 8.11 #365

merged 3 commits into from
Apr 4, 2024

Conversation

Mpdreamz
Copy link
Member

No description provided.

@Mpdreamz
Copy link
Member Author

Running into this: elastic/ecs#2326

@Mpdreamz Mpdreamz requested a review from stevejgordon April 4, 2024 12:24
stevejgordon
stevejgordon previously approved these changes Apr 4, 2024
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor nit

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mpdreamz Mpdreamz merged commit 7899022 into main Apr 4, 2024
5 checks passed
@Mpdreamz Mpdreamz deleted the feature/ecs-8.11 branch April 4, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants