feat: add missing store impls & add len
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblique
reviewed
Jun 25, 2024
|
Please add |
* `InMemoryBlockstore` * Traits: add `Clone` and `Debug` * Functions: add `len` * `LruBlockstore` * Traits: add `Debug` * Functions: add `len`
oblique
approved these changes
Jun 27, 2024
Merged
|
Released in 0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks!
I've been refactoring a library to use
Blockstoreinstead of my bespoke library-internal one, and found that it was difficult to test and debug a couple things. I've added a fewimpls (where possible), pluslenso that I can ensure some of my storage tests are exhaustive.InMemoryBlockstoreCloneandDebuglenLruBlockstoreDebuglenIt might make sense to put that
lenon theBlockstoretrait, but I figured on the lightest stores which have underlyinglens was the most conservative approach for now.Please let me know if I can add anything else, or if you'd like any changes :)