feat: send cannot execute event to amplifier #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzox
force-pushed
the
feat/send-cannot-execute-event-to-amplifier
branch
from
7ddef6d to
d5c050b
Compare
frenzox
commented
Dec 17, 2024
The signature is useful in case we need to retrieve logs for the transaction. Signed-off-by: Guilherme Felipe da Silva <[email protected]>
Signed-off-by: Guilherme Felipe da Silva <[email protected]>
frenzox
force-pushed
the
feat/send-cannot-execute-event-to-amplifier
branch
from
d5c050b to
5db5cd4
Compare
frenzox
commented
Dec 19, 2024
roberts-pumpurs
previously approved these changes
Dec 19, 2024
frenzox
force-pushed
the
feat/send-cannot-execute-event-to-amplifier
branch
2 times, most recently
from
ea307e0 to
e045c81
Compare
Using fetch_logs won't work here because it doesn't return the data for failed transactions. Besides that, we're lot really using the logs whereas fetch_logs fails if there is not logs. Signed-off-by: Guilherme Felipe da Silva <[email protected]>
frenzox
force-pushed
the
feat/send-cannot-execute-event-to-amplifier
branch
from
e045c81 to
091e174
Compare
Co-authored-by: Roberts Pumpurs <[email protected]>
roberts-pumpurs
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Sending feedback to the amplifier in case of failure to execute a message.
Related Issue(s)
Closes https://github.com/eigerco/solana-axelar-internal/issues/504
Checklist