Added global connection from ptap to GND #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry for the long wait! I would like to get this merged. |
|
Since sky130 supports a 3-well process, I think that handling substrate connections as global connections to possibly unconnected or multiply connected nodes is not wise. This needs further review in my opinion. |
|
Thanks @d-m-bailey! If I understand you correctly, that means that an isolated P-well connected to a ptap would automatically be connected to the global P-substrate, even if this is not the case in layout? That would be a problem indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
There has been issues with LVS failing due to ptap not being connected to global ground. This PR is a fix for that issue(#9 (comment)).
Looking forward for your review!!