Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow per-service Datadog APM enable for edxapp #8

Merged
merged 1 commit into from
May 14, 2024

Conversation

timmc-edx
Copy link
Member

This will allow us to enable Datadog for edxapp independently of other services during the migration. It also pushes the knowledge of the two common switches into the defaults layer so that only one variable needs to be consulted. Similar work for other services would follow.

I've also switched to a topic-first rather than an ENABLE-first naming convention since it tends to sort and group better.

This supports edx/edx-arch-experiments#632


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

This will allow us to enable Datadog for edxapp independently of other
services during the migration. It also pushes the knowledge of the two
common switches into the defaults layer so that only one variable needs to
be consulted. Similar work for other services would follow.

I've also switched to a topic-first rather than an `ENABLE`-first
naming convention since it tends to sort and group better.

This supports edx/edx-arch-experiments#632
@timmc-edx timmc-edx merged commit 4942912 into master May 14, 2024
4 checks passed
@timmc-edx timmc-edx deleted the timmc/dd-per-service-edxapp branch May 14, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants